Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Adjusted to fit some of the things mentioned here, thanks for the comment. Some things don't fit well here though.

1.75 line-height works well for some fonts I found, not unreasonably spacious in that case.

Headings were the only things that have overflowing issues here, so they were the only thing includes for `overflow-wrap`.

Removed `scale-down` on the images.

`!important` was used because of issues with Firefox, where it overwrote the styling with its own default styling. Might be fixed by now, will have to test that later.

> I’m guessing you haven’t used a CSS reset,

As shown in the guide, a CSS reset is used.

> What has this to do with Astro!?

Saw some frameworks wrap images in another <div> in this case, hence the mention. Also more beginner-friendly to mention the overall framework, not the underlying library.

Good catch about the curly quotes!

> Could have done `td, th` for the first rule and deduplicated

No, they are different, read the lines again.

Good catch about the comments via //, should use /* */ instead.

> It grates that, where normally you’re using obviously placeholder colors, just occasionally you use variables, sometimes gratuitous unnecessary ones.

It's a more gentle introduction to CSS variables, less overwhelming for beginners, you will change them in your own application anyways.

> Consider each declaration inside and whether it should be applied to all three of these selectors.

I found the part about code styling to work well for single word code and multiple line code, although looking back now it can be better yeah. If you have a good example of how to improve it I will add it!



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: